Skip to content

[EMCAL-834] Checking active links per trigger - #11640

Merged
davidrohr merged 1 commit into
AliceO2Group:devfrom
mfasDa:EMCAL-834
Jul 12, 2023
Merged

[EMCAL-834] Checking active links per trigger#11640
davidrohr merged 1 commit into
AliceO2Group:devfrom
mfasDa:EMCAL-834

Conversation

@mfasDa

@mfasDa mfasDa commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator

For each trigger checking from which DDLs the
reconstruction received pages. If we don't receive
pages from all active links the page is discarded.

@mfasDa
mfasDa requested a review from jokonig as a code owner July 10, 2023 09:02
@mfasDa
mfasDa requested review from davidrohr and shahor02 July 10, 2023 09:02
@mfasDa

mfasDa commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator Author

Re-introducing commit reverted in #11266. We will need this commit in order to drop timeframes where not all links are present, leading to inconsistent data.

Indeed there might be a prroblem with synthetic data, in case there are no pages created for links where we don't have data (@shahor02) - i this case the link checker is indeed supposed to fail. We might need to force writing empty pages in case of simulated raw data.

The crash reported by David points to a check for non-0 range in the framework:

[3679048:calib-emcalchannel-badchannel]: [09:44:47][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-calibration-emcal-channel-calib-workflow, device shutting down. Reason: deque::_M_range_check: __n (which is 0)>= this->size() (which is 0)

In this case the crash would also appear for true positives since in such cases we send emtpy vectors and would not pass the range check (@ktf). The framework must support also empty containers for such cases.

@mfasDa
mfasDa requested a review from a team as a code owner July 10, 2023 10:25
@mfasDa

mfasDa commented Jul 10, 2023

Copy link
Copy Markdown
Collaborator Author

I adapted the code in a way that it can be switched off via a config option and by default is switched off in case of simulated raw data. Like this it should be safe for running on synthetic raw.

For each trigger checking from which DDLs the
reconstruction received pages. If we don't receive
pages from all active links the page is discarded.

The link checker can be disabled via a corresponding
config option and is by default disabled in case of
running on simulated data.
@mfasDa

mfasDa commented Jul 11, 2023

Copy link
Copy Markdown
Collaborator Author

Slight modification: Task now sending a raw data error to the QC for each missing link

@davidrohr
davidrohr merged commit 9bbbc73 into AliceO2Group:dev Jul 12, 2023
@mfasDa
mfasDa deleted the EMCAL-834 branch July 12, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants